[uclibc-ng-devel] syscall cancel simplification patches

Waldemar Brodkorb wbx at uclibc-ng.org
Sat Jul 29 11:30:18 CEST 2017


Hi Max,

> Am 28.07.2017 um 04:16 schrieb Max Filippov <jcmvbkbc at gmail.com>:
> 
> Hi Waldemar,
> 
>> On Fri, Jul 21, 2017 at 12:31 PM, Waldemar Brodkorb <wbx at uclibc-ng.org> wrote:
>> I would like to get some feedback for following three patches.
>> The test suite runs over all architectures showed no regressions.
>> 
>> The goal is to simplify the addition of new architectures and
>> remove the need to add assembly code to sysdep-cancel.h.
>> 
>> Most of the work was done in 2011 in commit
>> 9f68f0cbf8c8eea6a7f9e195e4617bbaa808d7c6, but it was not finished
>> for NPTL and RT components of uClibc.
> 
> I've taken a look into it and got a couple of questions:
> - removal of CLONE_VM and CLONE_THREAD from libc/sysdeps/linux/*/clone.S
>  probably does not belong to the "nptl: remove asm from sysdep-cancel.h" patch.

I splitted the patch before pushing.

> - sysdep-cancel.h files now look very similar across all architectures,
>  and they no longer seem to be arch-specific. Should they now become a single
>  generic file?

Good idea, i will try this rework for the next release.

Thanks for your feedback,

best regards
 Waldemar


More information about the devel mailing list