[uclibc-ng-devel] [PATCH] xtensa: fix __sigsetjmp call12 case

Max Filippov jcmvbkbc at gmail.com
Fri Apr 1 19:06:39 CEST 2016


Hi Waldemar,

On Thu, Mar 31, 2016 at 8:44 PM, Waldemar Brodkorb <wbx at uclibc-ng.org> wrote:
>> Register window saving loop in __sigsetjmp incorrectly calculates offset
>> in the jmp_buf in case it was called with call12. The bug was introduced
>> in commit f4b1b7ade7971141 "xtensa: fix setjmp that didn't save all
>> registers correctly".
>
> Thanks, applied and pushed.
> How did you found it? No included testcase catched it, right?

Right. I was doing musl port
  https://github.com/jcmvbkbc/musl-xtensa/commits/xtensa-1.1.14
and looked very closely at the code I used as a reference. I'm pretty sure
that nobody ever called or will ever call __sigsetjmp with call12 though.

-- 
Thanks.
-- Max


More information about the devel mailing list